Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FullName for service route generation #601

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Use FullName for service route generation #601

merged 3 commits into from
Oct 3, 2023

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Oct 3, 2023 •
edited by akshayjshah
Loading

Use the protobuf runtime's FullName rather than our own, bug-prone implementation.

Fixes #597.

@emcfarlane emcfarlane changed the title protoc-gen: Use FullName for service route Use FullName for service route generation Oct 3, 2023
jhump
jhump approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

akshayjshah
akshayjshah approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd prefer to just remove the reflectionName function entirely - it's not doing anything useful anymore.

@akshayjshah akshayjshah merged commit 8a0c89f into main Oct 3, 2023
8 checks passed
@akshayjshah akshayjshah deleted the ed/fix-svc-name branch October 3, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

@jhump jhump jhump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If there is no package in the proto file, an unnecessary "." is added to the Path of the HTTP Handler.
3 participants
@emcfarlane @akshayjshah @jhump